jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
133 stars 89 forks source link

Add component props to swap border with shadow #3460

Open joshwooding opened 6 months ago

joshwooding commented 6 months ago

We need a toggle to swap the border for a shadow. This will affect:

pseys commented 6 months ago

Just flagging that this could be a particularly tricky one to do in Figma, as it's switching off one attribute in favour of another.

It may need some time to play through the possibilities. It may have to be a combination of things (not sure about code) e.g.

Borderless – removes borders from Cards, Dialogs, etc. Elevation – changes the shadow ramp from a predominantly flat design to a more elevated design

origami-z commented 6 months ago

Update to not be a theme feature but component

mark-tate commented 5 months ago

Zazu Goal: M(5)

bhoppers2008 commented 5 months ago

Moving to Americano in order to prioritise corner verification for theme release.

mark-tate commented 4 months ago

@bhoppers2008 when will we pick this up

origami-z commented 3 months ago

Blocked - pending stakeholder discussion