jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
132 stars 89 forks source link

Dropdown focus announcement bug in Safari / VoiceOver #3490

Open origami-z opened 6 months ago

origami-z commented 6 months ago

https://storybook.saltdesignsystem.com/iframe?args=&id=core-dropdown--with-form-field&viewMode=story

image
origami-z commented 6 months ago

Maybe related to https://github.com/select2/select2/issues/4349

origami-z commented 5 months ago

This is a Safari bug, given VoiceOver + Chrome worked

joshwooding commented 2 months ago

Definitely a webkit bug https://bugs.webkit.org/show_bug.cgi?id=231724

@jake-costa this is what I mentioned the other day

jake-costa commented 1 month ago

@origami-z @joshwooding Great call out. As Josh mentioned, this is a known issue for VoiceOver+Safari. Thoughts on adding to the a11y section on the site for awareness?

Resources: https://discussions.apple.com/thread/255614236?sortBy=rank https://github.com/w3c/aria-practices/issues/2060

joshwooding commented 1 month ago

@jake-costa we should definitely add it, could you draft something?

origami-z commented 1 month ago

Tested again today, with MacOS 14.7 (23H124) and Safari 18.0.1, no change to the bug. Navigation between items doesn't trigger announcement, also "completion selected" is still there

joshwooding commented 1 month ago

Can we check it this is an issue with Safari 18? I've read reports that it has been fixed.

origami-z commented 1 month ago

Can we check it this is an issue with Safari 18? I've read reports that it has been fixed.

I was testing Safari 18.0.1

joshwooding commented 1 month ago

Can we check it this is an issue with Safari 18? I've read reports that it has been fixed.

I was testing Safari 18.0.1

Weird... maybe it was 18.1

origami-z commented 1 month ago

+1 SO 92916

joshwooding commented 3 weeks ago

@jake-costa I can confirm this is no longer a problem in the latest version of Safari + MacOS but we should still document it as it will affect lots of users.

Tested on: 15.1 and Safari 18.1

We should test whether 18.1 is a older version of MacOS works.

jake-costa commented 3 weeks ago

@joshwooding I have Safari 18.1 but am unable to update my Mac to 15.1 (Currently on 14.7.1) to validate. That said, since you are confirming it is no longer an issue on 15.1, we can modify the documentation to say

Issue Details: OS: MacOS 14.X.X or Below MacOS 15.

Thoughts?