Overlay close button overlaps with content when no title is used - Githubissues

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customisation and ease-of-use

https://www.saltdesignsystem.com

Apache License 2.0

111 stars 78 forks source link

Overlay close button overlaps with content when no title is used #3532

Open origami-z opened 1 month ago

origami-z commented 1 month ago

Package name(s)

Core (@salt-ds/core)

Package version(s)

1.28.0

Description

In HD, overlay content will be overlapped with close button. And scroll bar will also overlay with close button.

Steps to reproduce

https://stackblitz.com/edit/salt-template-s3xizl?file=App.tsx,index.tsx

Expected behavior

No response

Operating system

[ ] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

Browser

[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

Are you a JPMorgan Chase & Co. employee?

[X] I am an employee of JPMorgan Chase & Co.

tomhazledine commented 5 days ago

Final amends following review to account for unpredictable source-order of OverlayPanel contents.
Ready for review.

bhoppers2008 commented 1 day ago

Pending design review from @bhoppers2008