jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
128 stars 89 forks source link

Tab component does not return to it's original visual state, when the browser resizes #3542

Open VAIBHAVHATISKAR21 opened 4 months ago

VAIBHAVHATISKAR21 commented 4 months ago

Package name(s)

Lab (@salt-ds/lab)

Package version(s)

@salt-ds/lab : 1.0.0-alpha.46

Description

Tab component doesn't adjust back to it's original visual state , when tab is moved from one monitor to another.

Steps to reproduce

Screen where tab component is implemented, 1) Try to move it from one screen to another 2) Tab will shrink in new screen

3) Now maximize the browser tab, it is still the same as it was in Step 2.

Expected behavior

Ideally it should expand back to it's original state , as the screen size is same in another monitor.

Operating system

Browser

Are you a JPMorgan Chase & Co. employee?

joshwooding commented 4 months ago

I tried to reproduce this on Storybook but wasn't able to. Could you provide a reproduction, please?

Note: The overflow in tabs isn't great and is currently being worked on, so it should improve in the future.

VAIBHAVHATISKAR21 commented 4 months ago

It can be reproduced in SALT website , When full screen, drag chrome to another monitor, Tab will get adjusted to MicroMenuIcon , but when Chrome is maximized back , it is still rendering MicroMenuIcon (which it should have rendered back to old state of Tab)

origami-z commented 4 months ago

Reproduce: shrink the Salt website window to around 1180px width on the tabs example, maximize the page, tabs are not reflowed.