jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customisation and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
109 stars 78 forks source link

Add bordered prop to Dropdown and fix Dropdown styles #3551

Closed ThusharaJ07 closed 1 week ago

ThusharaJ07 commented 3 weeks ago

3456

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 31311f1f4dbc231d6b1e584ef35bc0e6ce55ef86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------- | ----- | | @salt-ds/core | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 3 weeks ago

@ThusharaJ07 is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 11:14am
joshwooding commented 2 weeks ago

Looks like there was a regression on the HD height

ThusharaJ07 commented 2 weeks ago

Looks like there was a regression on the HD height

@joshwooding What does this mean? How can it be solved?

origami-z commented 2 weeks ago

Looks like there was a regression on the HD height

@joshwooding What does this mean? How can it be solved?

HD Dropdown used in Calendar, triggered a visual diff. Compare with Calendar QA story.

If you can see Chromatic diff: https://www.chromatic.com/test?appId=628e27029fcf95004a62cafd&id=666fe5a46eba6135fdb0693f

ThusharaJ07 commented 2 weeks ago

Something is weird, opening the dropdown via mouse, press down shows a thicker line than released?

@origami-z The active indicator is only there for active state. that is why. hmm. I will add it for focus state as well?

ThusharaJ07 commented 2 weeks ago

Do we need visual snapshot on validation status?

Hi @origami-z , what should be done for this? Not sure what this means.

origami-z commented 2 weeks ago

Do we need visual snapshot on validation status?

Hi @origami-z , what should be done for this? Not sure what this means.

Need to include bordered validation status in .qa.stories file so Chromatic can take visual regression