Salt Icon CSS background image doesn't not work with additional classname in front - Githubissues

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customisation and ease-of-use

https://www.saltdesignsystem.com

Apache License 2.0

109 stars 78 forks source link

Salt Icon CSS background image doesn't not work with additional classname in front #3583

Closed origami-z closed 1 week ago

origami-z commented 2 weeks ago

Package name(s)

Icons (@salt-ds/icons)

Package version(s)

v1.12.0

Description

When another classname is used before Salt icon css, icon is broken

https://github.com/jpmorganchase/salt-ds/blob/a5e47e3ac958a05d1a7afe6f43461fbc5d78675d/packages/icons/scripts/generateIcons.mjs#L64C21-L64C39

Steps to reproduce

https://stackblitz.com/edit/salt-template-xzwkid?file=App.tsx

Expected behavior

No response

Operating system

[X] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

Browser

[X] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

Are you a JPMorgan Chase & Co. employee?

[X] I am an employee of JPMorgan Chase & Co.

origami-z commented 1 week ago

Fixed in @salt-ds/icons@1.12.1