search

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
125 stars 89 forks source link

Figma: Dialog to add prehead option #3601

Open origami-z opened 3 months ago

origami-z commented 3 months ago

Add option to enable prehead in Figma component, in code: https://www.saltdesignsystem.com/salt/components/dialog/examples#preheader

yunjungyeh commented 3 months ago

Kick-off scheduled on Thursday 27 June

mark-tate commented 3 months ago

Goal: S(3) TBC Figma solution only

yunjungyeh commented 3 months ago

@origami-z: Dialog header has a prehead prop in code to add additional text above the main heading text. I have the site example link on GitHub issue. It’s reported by pepper users that it's not achievable in Figma. So need to add those, maybe through an optional Boolean prop in Figma, false by default.

yunjungyeh commented 3 months ago

Notes from KO:

@bhoppers2008: Size need to be updated to M

Start with the spec: Create a branch for prehearder text with title and when with Status icon (have prehearder section) Update the spec and using the right token

and test the components

Bugs to be fixed in Design too, bugs in code will have another new issue

mark-tate commented 2 months ago

@bhoppers2008 what is the state of this one for the Cappuccino sprint ? Maybe paused due to the other Header work, starting this sprint ?

origami-z commented 2 months ago

Aug 1: will be delayed to next Sprint (Cortado) with capacity and OOO.

mark-tate commented 1 month ago

Cortado Goal: close by EOS

origami-z commented 1 month ago

Aug 12 - header block progressing (#3800), to avoid users to update Figma more than once

joshwooding commented 1 month ago

Will be closed by #3839