search

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
125 stars 89 forks source link

Support status color for FormFieldHelperText #3603

Closed alexmotoc closed 2 months ago

alexmotoc commented 3 months ago

Using the color prop instead of the deprecated variant. It should now apply the success/warning/error colour to the helper text based on the form field status.

Should address #3540

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 09d7d6c27b9dccc4ed05c937d648c6d32c6caf0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------- | ----- | | @salt-ds/core | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 3 months ago

@alexmotoc is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

joshwooding commented 3 months ago

Needs a design review, @jpmorganchase/salt-design . Are we happy with this affecting all helper text? Do we want it to be optional

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:23am
joshwooding commented 2 months ago

Move to draft as waiting for design discussion.