jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customisation and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
109 stars 78 forks source link

Theme: Icon switching #3625

Open pseys opened 6 days ago

pseys commented 6 days ago

EOS: Approved approach to swapping Icons in Salt (Next) Figma library.

pseys commented 6 days ago

POC 1

Concept: Create 'semantic icon' component Outcome:

POC 2

concept: Add 'semantic icons' to existing Salt icon library and enable library swapping in Figma Outcome:

Summary

Option 2 seems to be the better solution, however, additional work needs to be carried out to the component library and icon library to test further.

Once these tasks have been completed a follow-up POC can be run.

mark-tate commented 6 days ago

Goal: Icon Library - change width/height color of all icons S(3) (Resolved in this 3628) Nested Icons - need to be changed from the icon component to icons directly from the Salt icon library (To be resolved in this issue)

pseys commented 6 days ago

Goal: Icon Library - change width/height color of all icons S(3) Nested Icons - need to be changed from the icon component to icons directly from the Salt icon library

I've created an issue for the first goal #3628

bhoppers2008 commented 5 days ago

Investigate if we need the icon and country symbol at all (in the Salt Next library) or can we control the scaling using the figma only variables.