Update Button component to use new styles

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customisation and ease-of-use

https://www.saltdesignsystem.com

Apache License 2.0

109 stars 78 forks source link

Update Button component to use new styles #3630

Open pseys opened 6 days ago

pseys commented 6 days ago

New variables have been added to the Salt (next) styles library to accommodate Bordered Button.

The button component needs to be updated to use the new variables.
appearance and color props needs to be added to Button
appearance: solid | outline | transparent color: neutral | accent need to be added to Button

Figma implementation of #3325

pseys commented 6 days ago

For the updated Button component I think the least disruptive solution is to do the following:

Change cta button to accent button -- Add appearance as a prop with 3 options solid (as default), outline and transparent
Change primary button to neutral button -- Add appearance as a prop with 3 options solid (as default), outline and transparent

TBC

Change all instances of secondary button across the component library to use neutral button set to transparent
Remove secondary button

mark-tate commented 5 days ago

Goal: S(3) Figma published, tokens ready by 25/06/24 Dev work to start 26/06/24

pseys commented 4 days ago

The button component is complete and ready to publish, however, I need to check through all of the components it is dependent on and change any references to cta|primary|secondary

pseys commented 3 days ago

All Figma components have been updated. button is ready to publish in Figma.