jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customisation and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
109 stars 78 forks source link

Combo Box would be good to not show empty list #3637

Open origami-z opened 5 days ago

origami-z commented 5 days ago

Area

UI Components

The problem

When filter combo box into an empty list, top and bottom bottom would still be shown and look very weird (especially when using rounded corner theme next options)

https://storybook.saltdesignsystem.com/?path=/story/core-combo-box--default&globals=themeNext:enable;corner:rounded;accent:teal

The solution

Not show list when empty

Alternatives and examples

Are you a JPMorgan Chase & Co. employee?