search

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customisation and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
109 stars 78 forks source link

Deprecate actionable tokens #3647

Open pseys opened 4 days ago

pseys commented 4 days ago

From a design perspective we are no longer using salt-text-action-letterSpacing within our component library. It is an outlier that only impacts buttons. The token can be deprecated and its use in code removed.

salt-text-textAlign-embedded and salt-text-action-textAlign both centre text. The latter is only used in Button. Opportunity to reduce the number of repetitive tokens in the DS.

origami-z commented 4 days ago

What's the replacement?

For Characteristics, we need to think about whether a potential use case for consumer overrides. Having "duplicate" is probably ok, given reducing duplicate is mostly a job of lower tier tokens