search

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customisation and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
109 stars 78 forks source link

Add Badge to Pill's related components #3650

Open mlmsmith opened 4 days ago

mlmsmith commented 4 days ago

This change is related to #25, adding a link in the right-hand column of the pill component back to badge

changeset-bot[bot] commented 4 days ago

⚠️ No Changeset found

Latest commit: ddfd69576a48ab9ccd6730731289f23a11621d89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 4 days ago

@mlmsmith is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

joshwooding commented 4 days ago

Hi @mlmsmith, thanks for the contribution. We require all external contributors to JPMC projects to complete our Contribution Licence Agreement (CLA). You can sign as an individual or as representing your company. You only need to do this once and it covers all current and future projects managed under our GitHub organization.

The contribution agreement can be found here JPMC CLA, follow the instructions to complete and return via email.

If you're a JPM employee please, contact me internally.

mlmsmith commented 3 days ago

Hi Josh,

Thank you for your email. I have completed and submitted the CLA, just waiting for it to be processed.

Kind regards

Michael

Sent from Outlook for iOShttps://aka.ms/o0ukef

From: Josh Wooding @.> Sent: Thursday, June 27, 2024 5:38:29 PM To: jpmorganchase/salt-ds @.> Cc: mlmsmith @.>; Mention @.> Subject: Re: [jpmorganchase/salt-ds] Add Badge to Pill's related components (PR #3650)

Hi @mlmsmithhttps://github.com/mlmsmith, thanks for the contribution. We require all contributors to JPMC projects to complete our Contribution Licence Agreement (CLA). You can sign as an individual or as representing your company. You only need to do this once and it covers all current and future projects managed under our GitHub organization.

The contribution agreement can be found here JPMC CLAhttps://github.com/jpmorganchase/.github/blob/main/jpmc-cla-20230406.md, follow the instructions to complete and return via email.

— Reply to this email directly, view it on GitHubhttps://github.com/jpmorganchase/salt-ds/pull/3650#issuecomment-2194232012, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AN2N2OW6DMPNCI7QTROHEWLZJPMRLAVCNFSM6AAAAABJ7KXC7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJUGIZTEMBRGI. You are receiving this because you were mentioned.Message ID: @.***>

joshwooding commented 3 days ago

Hi Josh, Thank you for your email. I have completed and submitted the CLA, just waiting for it to be processed. Kind regards Michael Sent from Outlook for iOS<aka.ms/o0ukef> …

Thanks for the quick reply

vercel[bot] commented 2 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 10:09am
joshwooding commented 2 days ago

I'll move this to draft as we're waiting for the CLA approval.