Ag grid floating filter column chooser list item doesn't have hover effect - Githubissues

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customisation and ease-of-use

https://www.saltdesignsystem.com

Apache License 2.0

109 stars 78 forks source link

Ag grid floating filter column chooser list item doesn't have hover effect #3671

Open origami-z opened 3 days ago

origami-z commented 3 days ago

Area

UI Components

The problem

Use below site example, click floating filter of "Capital" column, observe no list item hover effect on the column chooser. https://www.saltdesignsystem.com/salt/components/ag-grid-theme/examples#floating-filter

In v1.3.7 of the theme, there were hover effect on the list items.

The solution

Add hover style to ag-virtual-list-item

background color
cursor: pointer?
Adjust spacing between checkbox and text (very tight in HD)
Expand the clickable area of the set filter item (e.g. use padding instead of margin)

Alternatives and examples

-

Are you a JPMorgan Chase & Co. employee?

[X] I am an employee of JPMorgan Chase & Co.