jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
132 stars 89 forks source link

Figma Bugs Fix: Icon, Status Indicator (sizes not correct after variable applied in Icon Library) #3672

Closed yunjungyeh closed 4 months ago

yunjungyeh commented 4 months ago

After Icon library applied variable, there are Figma Bugs that need to be fixed Components that use Icon, Status Indicator, Button etc.

### Tasks
- [x] Fix: Icon sizes
- [x] Fix: Status Indicator and Icon bugs in Button/Avatar
- [x] Fix: Patterns that use Button, Icon bugs in Toggle Button
- [x] Fix: Banner - Button icon size update (reset to remove variable)
- [x] Fix: Form control component: Dropdown/Combobox/Single Date/Stepper Input
- [x] Fix: Calendar - button icon reset (to remove variable)
- [x] Fix: Link - icon reset (to remove variable) and update size
- [x] Fix: Pagination - button icon reset (to remove variable)
- [x] Fix: Pill - icon reset (to remove variable) and update size
- [x] Fix: Toast - button icon reset (to remove variable)
yunjungyeh commented 4 months ago

Figma Bugs fixed on Fri 28 June with the release:

Figma Bugs fixed and published on Mon 1 July: