jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
131 stars 89 forks source link

Figma H3 small text style does not use "Heading Font" option #3830

Closed origami-z closed 3 months ago

origami-z commented 3 months ago

Package name(s)

Core (@salt-ds/core)

Package version(s)

No response

Description

H3 small doesn't have "Heading Font" mode switch in Figma

Steps to reproduce

Select H3 layer and try mode switch (double hexagon icon), there is no heading mode

https://www.figma.com/design/e753bB0n5Adc0LCXqtvslu/Salt-(Next)-Style-Library?node-id=4440-2296&t=ictZNN9YmRUw0dlf-4

Expected behavior

No response

Operating system

Browser

Are you a JPMorgan Chase & Co. employee?

origami-z commented 3 months ago

Need to verify all text styles

pseys commented 3 months ago

The text style variable have become detached somehow. It's a simple fix I think but I need to check all styles to make sure its not wider spread

pseys commented 3 months ago

Fixed. The issue was limited to H3 Small and has been corrected. The Figma library has been published with the fix and a release note added explaining the fix.