jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
120 stars 87 forks source link

Facing Type Error in @Salt/lab 1.0.0-alpha.49 - Generic type 'ElementType' requires between 0 and 1 type arguments #3831

Closed ashwini-shinde-chase closed 1 month ago

ashwini-shinde-chase commented 1 month ago

Package name(s)

Lab (@salt-ds/lab)

Package version(s)

@Salt/lab 1.0.0-alpha.49

Description

[build:types] > build:types [build:types] > tsc [build:types] [build:types] C:/JPMC/DEV/TMP/MSPayments/dsp-merchant-dashboard-mfe/node_modules/@internationalized/date/dist/types.d.ts(152,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher. [build:types] C:/JPMC/DEV/TMP/MSPayments/dsp-merchant-dashboard-mfe/node_modules/@internationalized/date/dist/types.d.ts(193,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher. [build:types] C:/JPMC/DEV/TMP/MSPayments/dsp-merchant-dashboard-mfe/node_modules/@internationalized/date/dist/types.d.ts(223,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher. [build:types] C:/JPMC/DEV/TMP/MSPayments/dsp-merchant-dashboard-mfe/node_modules/@internationalized/date/dist/types.d.ts(272,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher. [build:types] C:/JPMC/DEV/TMP/MSPayments/dsp-merchant-dashboard-mfe/node_modules/@salt-ds/lab/dist-types/form-field-legacy/FormHelperText.d.ts(7,49): error TS2707: Generic type 'ElementType' requires between 0 and 1 type arguments. [build:*types] npm run build:types exited with code 2

Steps to reproduce

Execute tsc command. Using below versions: npm 10.5.2 node js - 20.13.1 "@salt-ds/core": "^1.32.0", "@salt-ds/icons": "^1.12.1", "@salt-ds/lab": "^1.0.0-alpha.49", "@salt-ds/theme": "^1.20.0",

Expected behavior

Expected to run build without errors.

Operating system

Browser

Are you a JPMorgan Chase & Co. employee?

joshwooding commented 1 month ago

Thanks for raising an issue, just curious have you tried changing your code to use the FormField from core? If you are using form controls from core it would be required.

ashwini-shinde-chase commented 1 month ago

Yes, FormField component, we are using from core. I am using DatePicker from lab.

origami-z commented 1 month ago

The error suggests you're lab form field? Which TypeScript version are you on?

@salt-ds/lab/dist-types/form-field-legacy/FormHelperText.d.ts(7,49):

ashwini-shinde-chase commented 1 month ago
"target": "ES2016"
Using as configured in tsconfig.json