search

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
129 stars 90 forks source link

Disable background scroll when Dialog open #3906

Open liamsms opened 2 months ago

liamsms commented 2 months ago

Area

UI Components

The problem

The current behavior of the Dialog component allows for background scrolling when the Dialog is open. This can sometimes lead to unintentionally scrolling the background content while interacting with the Dialog. It would be nice to have an option to disable this.

The solution

Add a new prop to Dialog which disables background scrolling. eg disableBackgroundScrolling: boolean

Alternatives and examples

.

Are you a JPMorgan Chase & Co. employee?

joshwooding commented 2 months ago

This seems like a defect and should be fixed.

mark-tate commented 2 weeks ago

@tomhazledine @Fercas123 for awareness of the issue, what is our recommended solution

mark-tate commented 2 weeks ago

grouped dialog issues into one sprint, needs further grooming, so dates subject to change

mark-tate commented 4 days ago

Latte Goal: review PR as it overlaps with Overlay