jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
121 stars 88 forks source link

Update Button Bar pattern in Salt Figma #3933

Open bhoppers2008 opened 1 month ago

bhoppers2008 commented 1 month ago

The following updates have been made to Next and need to be made to Salt Light & Dark.

Aug 2, 2024 update

Renamed components:

Why? Too specific. Generalising names caters for wider use cases.

Added Horizontal fill reverse component Updated all names so overrides persist across components when swapped Added Secondary actions boolean to all components Added Core 3rd button boolean to all components Tested all new updates to ensure components behave as expected Updated Preferences Dialog and Dialog component using Button Bar pattern Added Dialog QA story swapping Horizontal for Stacked Button Bar All descriptions, URLs, metadata updated

Deprecated Multi-step form and Destructive actions components Why? Both can be achieved using Horizontal and Horizontal reverse components. What does this mean? These components should be swapped for supported components. They will be removed in a future update.

### Tasks
- [ ] Salt Next
- [ ] Salt Light/Dark
- [ ] Check Button Bar Pattern Template after release
yunjungyeh commented 1 month ago

2 Aug - Updated boolean prop name to Core 3rd button and merged the branch in Salt Next

mark-tate commented 1 month ago

Cortado Goal: Update in Salt 1 for light/dark and merge

origami-z commented 1 month ago

Aug 12 - should be pushed to later sprint. Move to next sprint due to capacity.

mark-tate commented 3 hours ago

Sprint Goal - updated ButtonBar pattern guidance with Header can be used with Dialog & new buttons (could be a design task or design & dev)