jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
132 stars 90 forks source link

Holistic solution to applying defaults #3939

Open mark-tate opened 3 months ago

mark-tate commented 3 months ago

Issue: Find Holistic Solution for Adding 'Bordered' Property to Components

Description:

We are in the process of adding a 'bordered' property to all components, but this approach has a high cost for the users of the components. We need to explore a more holistic solution that could involve default props or theming. Additionally, we want to ensure that this solution can be reused for other use-cases, such as icon switching.

Tasks:

Research and Analysis:

Investigate the current implementation of the 'bordered' property across components. Identify the pain points and high costs associated with the current approach.

Explore Solutions:

Evaluate the feasibility of using default props to manage the 'bordered' property. Consider implementing a theming solution that can handle the 'bordered' property globally. Assess the potential for these solutions to be extended to other use-cases, such as icon switching. Prototype and Testing:

Present the proposed solutions to the team for review.

### Deliverables:****

mark-tate commented 3 months ago

Cortado Goal Link/Combine to Design ticket From Design POV we know what components need a border and why From a Dev POV we know how we can implement holistically

origami-z commented 3 months ago

Aug 12 - not started

origami-z commented 2 months ago

Aug 16 - not started, move to next sprint

mark-tate commented 1 month ago

if you need this feature, then bump the issue by adding your thoughts here. Until then we are bumping this to Q1/2025