Review read-only styling for Radio Button and Checkbox

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use

https://www.saltdesignsystem.com

Apache License 2.0

121 stars 88 forks source link

Review read-only styling for Radio Button and Checkbox #3941

Open liamsms opened 1 month ago

liamsms commented 1 month ago

Area

UI Components

The problem

When the theme mode is set to dark, selected read-only Radios are difficult to see against a dark background.

https://storybook.saltdesignsystem.com/?path=/story/core-radio-button--readonly&globals=mode:dark

The solution

Change the selected read-only foreground color to white when in dark mode.

Alternatives and examples

Are you a JPMorgan Chase & Co. employee?

[X] I am an employee of JPMorgan Chase & Co.

origami-z commented 1 month ago

Thanks for raising. Will take a look next sprint.

joshwooding commented 3 weeks ago

Should be a stretch goal, needs a more holistic solution. Looking at the read-only styles for checkbox and radio and ensuring that they are okay from a11y pov.

mark-tate commented 1 week ago

Bumped to Frappe as non-trivial change