jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
121 stars 88 forks source link

selectOnTab is potentially confusing for screen reader users #3967

Closed joshwooding closed 3 weeks ago

joshwooding commented 1 month ago

Package name(s)

Core (@salt-ds/core)

Package version(s)

latest

Description

Our a11y SME made a comment that selectOnTab is potentially confusing behaviour because Tab is a key that typically navigates only, therefore it should be disabled by default and a warning should be added to the page

Steps to reproduce

No response

Expected behavior

No response

Operating system

Browser

Are you a JPMorgan Chase & Co. employee?

origami-z commented 1 month ago

what is missing? can it be made accessible? APG example is doing this?

joshwooding commented 1 month ago

@origami-z I'll let Jake comment but using a key that is used for navigation is the issue

origami-z commented 1 month ago

Ok. Will need more details on these, otherwise someone may pick up the issue to work.

https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-select-only/#accessibilityfeatures

joshwooding commented 1 month ago

Ok. Will need more details on these, otherwise someone may pick up the issue to work.

w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-select-only#accessibilityfeatures

It's awaiting triage, hopefully they won't.

joshwooding commented 1 month ago

Relevant discussion: https://github.com/w3c/aria-practices/issues/2703

joshwooding commented 3 weeks ago

Closing at not an issue, our official stance is that we follow functionality/guidelines provided by the APG.