jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
126 stars 89 forks source link

Fix data attributes error on pass through props #4039

Closed origami-z closed 2 weeks ago

origami-z commented 1 month ago

Specifically chose to accept only data-* attributes (not any string like MUI), so that we're achieving the same level of acceptance when passing to an input. e.g. <input random> is not valid.

Ref - https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/data-*

3797

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 7ac6c7de68110ff0ad2a3779610241a4a2e00dff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------- | ----- | | @salt-ds/core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 5:04pm
origami-z commented 1 month ago

/release-pr

github-actions[bot] commented 1 month ago

🫰✨ Thanks @origami-z! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/ag-grid-theme@0.0.0-snapshot-20240829101109
yarn add @salt-ds/core@0.0.0-snapshot-20240829101109