search

jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
132 stars 89 forks source link

Country Symbol CSS as background not bundled by webpack #4184

Open origami-z opened 2 months ago

origami-z commented 2 months ago

I'm trying to use country symbol via CSS background, i have below imports

import '@salt-ds/countries/saltCountries.css'
import '@salt-ds/countries/saltSharpCountries.css'

Above CSS is not getting bundled in my app, which i suspect is to do with webpack treeshaking

https://github.com/jpmorganchase/salt-ds/blob/39277e0ad8ad4d28a34e4c2883fdb947d4717f57/packages/countries/package.json#L15

The change was originally made in #1764, which needs further testing of the impact

Source: SO Question 91530

One potential workaround: import country symbol CSS in CSS files.

mark-tate commented 1 month ago

related #4217

mark-tate commented 4 weeks ago

Lungo Goal: scope work by EOS

origami-z commented 2 weeks ago

No dev capacity, push out a sprint