jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
125 stars 89 forks source link

Define solution to resolve button requirement for System Status #4188

Open bhoppers2008 opened 3 days ago

bhoppers2008 commented 3 days ago

Description Currently the System Status component is misusing sentiment buttons in order to provide inline actions. Salt provides guidance that sentiment buttons should be used/ considered independantly of status (i.e., just because an 'error' status is used, does not mean a 'negative' sentiment button is the correct choice).

Furthermore, two problems exist:

  1. In current theme, sentiment solid buttons are not the same color as the status background.
  2. In Next theme, status is currently not wired up to accent palette group in the same way that sentiment is wired up to accent. This means in Ligh/Dark Teal modes, teal buttons are displayed on the Info System Status.

Requirement Identify a holistic solution which enables actions to be displayed inline within the System Status component and doesn't conflict with our guidance on use of sentiment buttons relative to status.

Stakeholder Global banking/ Pepper pattern library.

Goal The goal of this issue is to agree a written proposition that we can confidently move into design and development.

origami-z commented 3 days ago

Scope to define before thinking about visual implementation (notes for myself)


Token consideration: Actionable - >

Contrast: there isn't an universal formular to calculate contrast with transparency. Can we only use eye drop on our existing status strong colors to test?

dplsek commented 1 day ago

Salt Next design proposal

Salt Current design proposal