jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
132 stars 89 forks source link

Correct Button letterspacing in Figma #4341

Closed pseys closed 4 days ago

pseys commented 4 weeks ago

Letterspacing for buttons in code is set to 0.6 whereas in Figma it is currently set to 0.0. This means buttons are marginally smaller in Figma than in code which could result inaccuracy between design specs and coded UIs

mark-tate commented 3 weeks ago

Lungo Goal: in Figma letter spacing is not applied to Buttons (exists in code)

pseys commented 2 weeks ago

On review, 3 issues were found with the action font style in Figma. The following has been corrected:

Action font letter spacing

Action font weight variable name

Action font weight variable value

The branch has been merged, but not yet published.

pseys commented 2 weeks ago

@bhoppers2008 please let me know if you're happy for me to merge the changes. I've QA'd the Action text style and it's displaying correctly. Once published the component library will need to run an update but it will only have a very minor impact on Button, Toggle Button and Pill.

I can publish the change without the component library being updated for now if you'd like to delay the second part.

mark-tate commented 1 week ago

Macc Goal: Ben to review, close by EOS @pseys to close ticket once we update made

pseys commented 1 week ago

The component and pattern library has now been updated with the bug fix. It just needs to be published as part of the next release.

pseys commented 4 days ago

This has been updated in the latest release (15 November)