Closed pseys closed 4 days ago
Lungo Goal: in Figma letter spacing is not applied to Buttons (exists in code)
On review, 3 issues were found with the action font style in Figma. The following has been corrected:
Action font letter spacing
action-letterSpacing
variable missingaction-letterSpacing
added with a value of 0.6
and referenced by Action/Default Text StyleAction font weight variable name
action-fontWeight
variable name incorrectaction-fontWeight-strong
changed to action-fontWeight
Action font weight variable value
action-fontWeight
variable value for Amplitude mode-value incorrectaction-fontWeight
changed from fontWeight-semiBold
to fontWeight-medium
for Amplitude modeThe branch has been merged, but not yet published.
@bhoppers2008 please let me know if you're happy for me to merge the changes. I've QA'd the Action text style and it's displaying correctly. Once published the component library will need to run an update but it will only have a very minor impact on Button, Toggle Button and Pill.
I can publish the change without the component library being updated for now if you'd like to delay the second part.
Macc Goal: Ben to review, close by EOS @pseys to close ticket once we update made
The component and pattern library has now been updated with the bug fix. It just needs to be published as part of the next release.
This has been updated in the latest release (15 November)
Letterspacing for buttons in code is set to 0.6 whereas in Figma it is currently set to 0.0. This means buttons are marginally smaller in Figma than in code which could result inaccuracy between design specs and coded UIs