jpmorganchase / salt-ds

React UI components built with a focus on accessibility, customization and ease-of-use
https://www.saltdesignsystem.com
Apache License 2.0
132 stars 89 forks source link

Fix HD Toast icon alignment #4357

Open liamsms opened 3 weeks ago

liamsms commented 3 weeks ago

Closes #3524

In the Figma spec, the icon has a padding-top of 1px in HD, the other densities use 2px.

In code, the padding-top value is combined with the margin-top value, I've updated it so that HD now uses 1px instead of 2px.

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 1d42a416f1c43c090974912131521a7004919afa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | ------------------ | ----- | | @salt-ds/core | Patch | | @salt-ds/countries | Patch | | @salt-ds/data-grid | Patch | | @salt-ds/lab | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 3 weeks ago

@liamsms is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

joshwooding commented 3 weeks ago

Thanks @liamsms, I've left a comment in the issue but I think we'll need design feedback since we should align to what's been done in Figma.