jpmschuler / powermail

This is the official repository of the TYPO3 extension powermail! Powermail is a well-known, editor-friendly, powerful and easy mailform extension for TYPO3
https://forge.typo3.org/projects/extension-powermail/
0 stars 0 forks source link

Feature #80805 (forge.typo3.org) #1

Closed jpmschuler closed 7 years ago

jpmschuler commented 7 years ago

powermail mail list module: using a core link builder for attachments to add compatibility with "secure_downloads" The link is build in Resources/Private/Partials/Module/List.html:197 with \In2code\Powermail\ViewHelpers\Misc\GetFileWithPathViewHelper. If you're interested in doing a pull request, feel free. Otherwise I will close this issue or set it on hold.

jpmschuler commented 7 years ago

(reproducing #80805 as it is non-public now):

jpmschuler commented 7 years ago

Szenario:

Problem:

Suggestion: As the TYPO3 file module itself works fine, I wonder if powermail perhaps uses string concatenation there instead of a TYPO3 core link builder for the mail list module, and if that is causing the incompatibility here. A quick look in secure_downloads comes up with a SignalSlot\Dispatcher architecture, with

'TYPO3\\CMS\\Core\\Resource\\ResourceStorage',
'\TYPO3\CMS\Core\Resource\ResourceStorage::SIGNAL_PreGeneratePublicUrl,

so on first glance it seems that if powermail would use a core/FAL function to create this link, it would solve this problem (and perhaps even improve situations with obscure ResourceStorages, like cloud services).

I'm sorry, but due to the complexity of powermail, I have no suggestion where to look/fix on that side.

jpmschuler commented 7 years ago

This should also allow for storing attachments in different storage types than folders... AWS cloud storage or something. However I currently cannot check for this and don't know if changing retrieval is enough (as there probably is a different function for saving the attachments). Just wanted to mention this for further reference if anybody stumbles upon this in a search.