search

jpochyla / psst

Fast and multi-platform Spotify client with native GUI
MIT License
8.56k stars 219 forks source link

Makes Sidebar/Main_view split resizable #448

Closed Liberontissauri closed 4 months ago

Liberontissauri commented 10 months ago

I use a tilling window manager and it throws me off how large the sidebar is because of the window occupying the whole screen. Makes the split between the sidebar and the main view draggable so it can be resized.

Liberontissauri commented 10 months ago

Maybe adding a setting in the preferences to persist the ratio between app launches would be nice, although I'm not sure about how to implement that just yet

jacksongoode commented 10 months ago

I question whether this would eventually lead to more layout bugs to resolve. If there is a way to set some min/max threshold of the side bar's resizing I think this could be acceptable. @Insprill any thoughts?

Liberontissauri commented 10 months ago

Weirdly so, the sidebar already does have a minimum threshold for its size:

minimum_sidebar_size

I cant reduce it further. I'm not sure if this is part of druid itself, or if there's a way to change it. It does look like it exists to prevent overflow that makes content "invisible".

Liberontissauri commented 10 months ago

Looks like it also applies to increasing the sidebar's size: image

jacksongoode commented 10 months ago

If you can set reasonable ratios that would keep the current min and make the max Not more than 1/3 of the width, I think that might resolve any issue with the sidebar being too wide as in your example.

jacksongoode commented 5 months ago

@Liberontissauri Any followup with the suggested constraints?

jacksongoode commented 4 months ago

I'm going to close this since its a tiny change to the PR and making the sidebar dragable would introduce lots of other issues. There may be a future where we can have a button/shortcut to collapse. If you'd like, please feel free to discuss UI ideas here https://github.com/jpochyla/psst/issues/476