jpochyla / psst

Fast and multi-platform Spotify client with native GUI
MIT License
8.54k stars 218 forks source link

Arm build for Linux #489

Closed jacksongoode closed 4 months ago

Insprill commented 4 months ago

I'd suggest we use cross to build for multiple architectures.

jacksongoode commented 4 months ago

I'd suggest we use cross to build for multiple architectures.

Thanks, I'll give it a go, this initial PR was just a stab in the dark.

jacksongoode commented 4 months ago

@Insprill If you have any experience with cross, I'd be happy for your help. It seems there are some issues with packages needed to be installed for each architecture.

jacksongoode commented 4 months ago

@Insprill Took long enough... anyways let me know if you have any suggestions with the current implementation. One thing I removed was the cargo test. We could add that back as an independent job if you think its useful but because the Linux builds are happening in Docker images (for now until arm runners are public), we would have to install the dependencies twice.

jacksongoode commented 4 months ago

@Insprill I'm going to go ahead since I can't see any major consequence. We can add back the test if we'd like in a later PR.