search

jpochyla / psst

Fast and multi-platform Spotify client with native GUI
MIT License
8.56k stars 219 forks source link

Linux GUI title bar is not dark in dark mode on Gnome #510

Closed emilia-miki closed 3 months ago

emilia-miki commented 3 months ago

Describe the bug On linux with GNOME as the DE, putting system appearance in dark mode and psst into dark mode in settings still keeps the title bar light.

To Reproduce Install psst on linux with GNOME, use dark mode both in GNOME and psst.

Expected behavior I expect the title bar to be dark, like the rest of the UI.

Screenshots image

Environment

Additional context https://github.com/jpochyla/druid seems to be discontinued now, ideally it should be replaced with something that's more maintained. I didn't investigate druid much yet, maybe it uses an older version of GTK which is not configured properly on my machine. I haven't written any code in Rust since some uni projects, but if I have the time I'll try to get more info.

emilia-miki commented 3 months ago

solved by setting environment variable GTK_THEME=Adwaita:dark

jacksongoode commented 3 months ago

Right, druid could be replaced, however the amount of work would be quite a lot and it would be nice to at least get this project into a confident bug-less state first. Is there something we can do to fix this so you don't have to set it yourself?

emilia-miki commented 3 months ago

Right, druid could be replaced, however the amount of work would be quite a lot and it would be nice to at least get this project into a confident bug-less state first. Is there something we can do to fix this so you don't have to set it yourself?

Apparently you can't, because it's controlled by the window manager. Unless you're willing to draw a fully custom titlebar with https://docs.gtk.org/gtk3/class.HeaderBar.html, and I'm not sure if druid has some wrappers for that.

The problem is that GTK4 works correctly with both Adwaita-dark and Adwaita:dark as the theme name, but GTK3 accepts only Adwaita:dark, and my system by default used Adwaita-dark. Maybe you could add this to some FAQ or a warning log, but not much more.