search

jpochyla / psst

Fast and multi-platform Spotify client with native GUI
MIT License
8.56k stars 219 forks source link

New authentication flow to resolve #515 #517

Closed jacksongoode closed 2 months ago

jacksongoode commented 3 months ago

This resolves the issue with a new OAuth method largely referencing the work done in librespot https://github.com/librespot-org/librespot/pull/1309. After this username/pass is completely depreciated. I may not have removed all unused references so I'd be happy for reviews and edits.

jacksongoode commented 3 months ago

@Insprill Since this is a big one and high prio, would you have time to look over this and review?

jacksongoode commented 3 months ago

@SO9010 Just to check with another person, does this method work for you from this branch?

kingosticks commented 3 months ago

By the way, now everyone required is back from holiday we'll hopefully be merging our librespot PR for this. It's currently going through some review. The intention is to publish a librespot-oauth create but when that'll see an actual release, I can't say. I appreciate you might prefer to control your own copy of that code, this is more just a note that the original version is seeing some updates (error handling mostly) so there may be value in waiting for those.

SO9010 commented 3 months ago

@SO9010 Just to check with another person, does this method work for you from this branch?

I'll try it out tomorrow!

jacksongoode commented 3 months ago

By the way, now everyone required is back from holiday we'll hopefully be merging our librespot PR for this. It's currently going through some review. The intention is to publish a librespot-oauth create but when that'll see an actual release, I can't say. I appreciate you might prefer to control your own copy of that code, this is more just a note that the original version is seeing some updates (error handling mostly) so there may be value in waiting for those.

@kingosticks Thanks for the update, I've been following changes to that PR. I think it does just make sense to roll our own implementation here. If you notice anything odd here feel free to point it out, it was based around your work so thank you!

SO9010 commented 3 months ago

@jacksongoode This works perfectly for me!!!