Deduplicate code and fix a few clippy complaints

jpochyla / psst

Fast and multi-platform Spotify client with native GUI

MIT License

8.55k stars 218 forks source link

Deduplicate code and fix a few clippy complaints #549

Closed itsjunetime closed 4 weeks ago

itsjunetime commented 1 month ago

While I was working on #548, I noticed a few areas where code was unnecessarily copied or did extra work/computation that it didn't need to do. Most of that was in the WebApi client struct, but there were a few other instances elsewhere as well. There were also some issues that clippy was complaining about which I took care of.

As far as I can tell, everything still works just as expected after these changes.

jacksongoode commented 1 month ago

Awesome! Thank you for your contribution - I'll have a look now!