search

jpodwys / cache-service-redis

A redis plugin for cache-service.
MIT License
7 stars 9 forks source link

support nameSpace #14

Closed hugosato closed 6 years ago

hugosato commented 6 years ago

The nameSpace is a config property for cache-service. This will help our test harness because the clean the keys based on nameSpace.

jpodwys commented 6 years ago

Thanks for this, should be useful!

A note--it's possible that some users are already passing in namespace. As such, merging this PR will change all of their keys and may break their tests. I think we should cut this as a major release to avoid breaking anyone's deploys. Thoughts?

hugosato commented 6 years ago

Yes, I think that's a potential breaking change. It's likely a major release.

jpodwys commented 6 years ago

It looks like merging this PR removed the JSON changes in your prior PR. Please submit another PR to add the JSON changes and then I'll cut a release.