search

jpoehls / dotnetmigrations

DotNetMigrations is a database migration framework that assists in managing and versioning database changes. It was originally designed as a straight port of the rails functionality located in the Ruby on Rails framework; however, has recently moved into a more open framework thanks to the power of the Managed Extensibility Framework.
Other
36 stars 10 forks source link

Fixed bug in master causing all commands to trigger a non-ending loop #22

Closed kieranbenton closed 13 years ago

kieranbenton commented 13 years ago

CommandBase was still calling Run(IArguments) instead of Execute(TArgs).

Hopefully this patch is in a reasonable format for you? Afraid I'm fairly green with github and git in general so could do with a few pointers :)

jpoehls commented 13 years ago

Looks like you've got some really good stuff here. I'll see what I can do to pull some of this in. I'm not terribly familiar with pull requests yet either but if there is some way you could split these into several pull requests that would help a lot. I'm not sure I'm ready to pull everything in just yet, but some of this definitely.

Separate pull requests for b449c33 (detached console env), c417299 (infinite loop fix), and the CombineCommand addition would be great.

Thanks! (And I'm very sorry it has taken me so long to address this. I've been totally out of DNM for so long, hard to get back in.)

jpoehls commented 13 years ago

I've cherry picked your commits b449c33 (detached console env), c417299 (infinite loop fix).

Please send another (new) pull request for just the addition of the CombineCommand and I'll review it for inclusion separately. Thanks again!