search

jpoehls / vscode-json-escaper

JSON escape/unescape extension for VS Code
8 stars 2 forks source link

Tab characters not escaped. #2

Closed Josee9988 closed 4 years ago

Josee9988 commented 5 years ago

Hi sir, I've just used your extension and It simply does what it is supposed to do, but I think you could improve it by escaping tab characters.

Example: https://i.imgur.com/oXeyI0L.png

As you can see it just add a lot blank spaces instead of using two or three \t.

It makes the json bigger in size and slower.

Thanks for the extension!

jpoehls commented 4 years ago

Thanks for taking the time to mention this. I finally got around to testing it and I wasn't able to reproduce. I'm using JSON.stringify() to escape the string so this behavior may have changed in a recent VS Code update due to them upgrading the underlying version of Chrome? Not sure.

Feel free to re-open if you are still seeing this behavior in VS Code 1.44.1 or newer.

Here is what I tested with:

Before:

{
    try {
        "hi"
    }
}

After escaping:

{\n\ttry {\n\t\t\"hi\"\n\t}\n}