search

jpoehnelt / secrets-sync-action

A Github Action that can sync secrets from one repository to many others.
https://github.com/marketplace/actions/secrets-sync-action
Apache License 2.0
314 stars 93 forks source link

docs: no classic token needed anymore #93

Closed SvenStaehs closed 1 year ago

SvenStaehs commented 1 year ago

The readme says about the github_token input A "Classic" personal access token is required. The "Fine-grained" tokens cannot be used as they do not support the GraphQL API at this time.
I've noticed that I cannot generate classic tokens on our Enterprise 3.7 instance, so I tried a scoped token, and it worked fine with the full "repo" scope.

I suspect the required permissions have been added to this scope at some point, so should the readme be updated? Or does this only apply in specific circumstances? Do we know which GHES version this applies to and in which a fine-grained token works?
Maybe it should cover all bases and state something like This token should have the full "repo" scope. In older instances of GitHub, a fine-grained token may not support the required GraphQL API and a "Classic" personal access token would be required. As this is deprecated, please try a fine-grained token first.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 1.7.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: