jpoet / HauppaugeUSB

MythTV wrapper around the Hauppauge HD-PVR2/Colossus2 driver
GNU General Public License v3.0
16 stars 5 forks source link

Restructuring plus some fixes #16

Open pal-saugstad opened 5 years ago

pal-saugstad commented 5 years ago

In this branch, the Hauppauge core driver is included by means of a git submodule. This makes the build process easier to automate.

In addition, there are some fixes: hauppauge_hdpvr2 -> commit 3403282: Enable PAL color decoding HauppaugeUSB -> commit e10ecff: Init audio in CVBS mode

Also changed: Some result files have been moved to locations which I consider to be more in line with the general Linux recommendations.

pal-saugstad commented 5 years ago

There might be a problem with the audio when using this version. I discovered this when I power cycled the system. I don't know (for now) what the problem is and which specific input configurations are affected. I will debug this ASAP.

jpoet commented 5 years ago

Thank you very much for helping to improving this code.

I completely agree that incorporating the Hauppauge code make it much easier to manage. The reason I didn't do that to begin with, is because of licensing. A lot of the Hauppuage code has copyright notices with no statements about permission to copy or modify, which makes me a bit nervous. When I asked Hauppauge about it, they said they didn't think I needed to worrie about it, but I would hate to get sued.

pal-saugstad commented 5 years ago

Right, I see that there might be problems regarding licensing when looking through the source code of the Hauppauge driver.

pal-saugstad commented 5 years ago

Hauppauge has now indicated that they are going to clarify the license issues soon.

pal-saugstad commented 5 years ago

Hauppauge and my company, NSSLGlobal Technologies AS, have now (yesterday) signed an agreement which states that we may modify the source code of the original Hauppauge driver and distribute it. I assume that @jpoet and Hauppauge will sign a similar explicit agreement.