search

jponge / vertx-gradle-plugin

An opinionated Gradle plugin for Vert.x projects
Apache License 2.0
113 stars 15 forks source link

Gradle 4.4 and some Readme badges #11

Closed amdelamar closed 6 years ago

amdelamar commented 6 years ago

Hi - Just wanted to help out by adding a release version badge, and license badge to the README.

Also, updated Gradle wrapper's version to 4.4. I did ./gradlew clean build and didn't have any issues. But please try on your end as well.

Thanks

amdelamar commented 6 years ago

Up to @jponge if the "version/tag" badge should link to Gradle Plugin page, GitHub releases page, or no link at all. I'd think users should see it link to plugins.gradle.org for validity that this is the very same plugin code. And license is of course optional fluff.

jponge commented 6 years ago

Git tags are a good indicator of what is the latest version so that badge is useful.

The LICENSE one is more a decorative one :-)

On Tue, Dec 12, 2017 at 5:33 PM, Austin Delamar notifications@github.com wrote:

Up to @jponge https://github.com/jponge if the "version/tag" badge should link to Gradle Plugin page, GitHub releases page, or no link at all. I'd think users should see it link to plugins.gradle.org for validity that this is the very same plugin code. And license is of course optional fluff.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jponge/vertx-gradle-plugin/pull/11#issuecomment-351106965, or mute the thread https://github.com/notifications/unsubscribe-auth/AABlabvnT-LgHQ8oHZDHE4w4W02Xb_-jks5s_qragaJpZM4Q7ly1 .

jponge commented 6 years ago

Thanks!