search

jponge / vertx-gradle-plugin

An opinionated Gradle plugin for Vert.x projects
Apache License 2.0
113 stars 15 forks source link

Ability to "blacklist" certain vertx version with known issue? #34

Open AndierZ opened 4 years ago

AndierZ commented 4 years ago

I noticed this when using the plugin version 0.5.0, which uses Vert.x 3.7.0 by default. In that particular version, BodyCodecImpl.java from vertx.web.common and the interface it references: WriteStream.java from vertx-core-3.7.0.jar, are out of sync. The method signature for the "end" method doesn't match.

Is there a way to flag versions like that as "invalid", so the plugin won't allow them? Will save a lot of debugging for people I suppose.

Really appreciate the work you guys did.

jponge commented 4 years ago

I'd say it is best to follow the recent versions of Vert.x than have the plugin maintain a list of versions to blacklist. I think 3.7.0 was more an exception than the norm.