jporter-dev / codewords

162 stars 39 forks source link

Standardize dictionary importing #24

Closed jporter-dev closed 4 years ago

jporter-dev commented 6 years ago

Make it easier for community dictionary contributions. Must support multiple dictionaries for multiple languages (English standard, English CAH, French standard, French CAH, etc...)

Ideas for doing this:

See additional input and discussion in this PR.

fdenzer commented 5 years ago

Hi, two-fold question here:

I would go about dictionaries of languages using an i18n-framework in vue, like vuex-i18n or simply vue-i18n. Any comment on the idea to use PO-Edit or JSON-files to translate the UI, too? I guess lists of text are easier for non tech-savy people, but as long as there is no client side provision of text for this application (e.g. via URI parameters), a pull-request seems to lock out ``normal'' users anyway?

Second question: if found a word at first glance that made no sense to me. After consulting a wiki I found out it is a very technical word. What are will the procedures for discussion of lists be in your (future) dictionary setup?

(That word is Krümmer, which is not a word most germans actually know [citation needed]. It is found in Line 171 of german txt )

jporter-dev commented 5 years ago

Using an i18n plugin does seem like a good idea, but would require an overhaul of the dictionary files. I would need help of native speakers to help translate to maintain the same word sets. I am also not sure if the words from the English set correlate one-to-one with German, French, etc, which is why I've relied on others to supply those files for me.

Using i18n to translate the UI is 100% a great idea. I will open up a separate PR for this since it is unrelated to the dictionary system.

If you have any other options for more user-friendly dictionary submissions or edits I'm open to suggestions.

jporter-dev commented 4 years ago

Revisiting this as the number of dictionaries is growing. Plan is to use a dictionaries.yml file to point to each dictionary. File will contain the keys [name, language, path].

@fdenzer - Issue #35 addresses the i18n aspect of the UI. This is 100% on the to-do list once I fix some performance issues and do a bit of refactoring/updating.

As for the word that made no sense - if there exists a more common word to replace it with feel free to update it. Or notify me and I can do it. I believe the German dictionary was provided by @IBFAIT so they may be able to weigh in here.

jporter-dev commented 4 years ago

Dictionary info is now stored in dictionaries.yml