search

jporter-dev / codewords

162 stars 39 forks source link

Application secret key visible in source code #37

Closed dalymople closed 5 years ago

dalymople commented 5 years ago

See line 19 in codenames/server/init.py Might be a good idea to store this as an environment variable instead and replace with;

import os
app.secret_key = os.environ.get('SECRET_KEY')
jporter-dev commented 5 years ago

Secret key moved to env

TheCatCameBack-poopyhead commented 5 years ago

What does that mean kitty

On Sun, Sep 15, 2019 at 7:31 PM Joshua Porter notifications@github.com wrote:

Secret key moved to env

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/joshporter1/codenames/issues/37?email_source=notifications&email_token=ANAGPHAX3TWBMPVY2GW4HKTQJ3HWTA5CNFSM4G66UVT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6X4LPI#issuecomment-531613117, or mute the thread https://github.com/notifications/unsubscribe-auth/ANAGPHHEGKCOZJ4WTZ7DRWLQJ3HWTANCNFSM4G66UVTQ .