search

jpos / jPOS-EE

jPOS Extended Edition
http://jpos.org
GNU Affero General Public License v3.0
107 stars 152 forks source link

Logback 1.3.x is for java 8 and 1.4.x is for java 11 #292

Open mchhil-incomm opened 8 months ago

mchhil-incomm commented 8 months ago

I see the changelog https://github.com/jpos/jPOS-EE/wiki/ChangeLog#jpos-ee-229----released-2023-12-23 has logback upgraded to 1.4.2 https://github.com/jpos/jPOS-EE/commit/230766b4

This wont work if java 8 is being used for building (I had run into this issue when I was upgrading libs due to CVE)

image

ar commented 8 months ago

Good point @mchhil-incomm — good catch, but please note this commit:

commit 745a060601c5180c711f7e36f6571ca06274c5c3
Author: Alejandro Revilla <apr@jpos.org>
Date:   Wed Nov 9 09:24:57 2022 -0300

    Stay with logback 1.2.8 as 1.4.x series baselines at java 11

    We'll move up soon.

ChangeLog is wrong, and I just fixed it.

Now that we just released jPOS-EE 2.2.9, I think it's a good time to move 2.2.10 to baseline in Java11 and we can upgrade to 1.4.2.

I'll keep this issue open, as a reminder to do that.

mchhil-incomm commented 8 months ago

Thank you for the update.