Should fix #508 by using a ConcurrentHashMap. Also refactored dump a bit. Functionally it is exactly the same.
About the issue ConcurrentHashMap has weak consistency guarantees but will handle mid iteration insertions transparently. Could still potentially dump inconsistent data if an insertion happens mid iteration as in there's no guarantee the iterator is actually updated with new entries but it's a tradeoff.
The alternative would be to lock any access to the map but seems overkill for a SystemMonitor dump and would probably perform worse as we would have to lock on get() which ConcurrentHashMap tries to avoid. Collections.synchronizedMap() does not solve this issue either.
On another note, to be honest I couldn't find where exactly someone might put a channel mid iteration. ISOServer seems to only support a single channel at a time.
Should fix #508 by using a ConcurrentHashMap. Also refactored dump a bit. Functionally it is exactly the same.
About the issue ConcurrentHashMap has weak consistency guarantees but will handle mid iteration insertions transparently. Could still potentially dump inconsistent data if an insertion happens mid iteration as in there's no guarantee the iterator is actually updated with new entries but it's a tradeoff.
The alternative would be to lock any access to the map but seems overkill for a SystemMonitor dump and would probably perform worse as we would have to lock on get() which ConcurrentHashMap tries to avoid. Collections.synchronizedMap() does not solve this issue either.
On another note, to be honest I couldn't find where exactly someone might put a channel mid iteration. ISOServer seems to only support a single channel at a time.