jpotterm / chrome-resizable-speaker-notes

A Google Chrome extension for Google Slides that makes the speaker notes sidebar resizable.
0 stars 2 forks source link

Extension is not working with google apps for work and german language #1

Open deafsquad opened 9 years ago

deafsquad commented 9 years ago

somehow the script is not triggered, i tried to debug, but for me it looks like it is not even getting to the name.match(/^punch_speaker_notes/) in https://github.com/jpotterm/chrome-resizable-speaker-notes/blob/master/injected_script.js

jpotterm commented 9 years ago

Thanks for the bug report! It's going to be a little hard to figure out the problem since I probably won't be able to reproduce it on my computer. But if you're willing to try some things out for me, we might be able to get to the bottom of this.

First things first. What's the URL of the document you're viewing? This extension only runs on pages that match "https://docs.google.com/presentation/" or "https://docs.google.com/a//presentation/*". I thought that covered all alternatives but maybe not.

Next let me know the name of the speaker notes window. You can find this by presenting with speaker notes and then while the speaker notes window is focused open the javascript console (More Tools > JavaScript Console). Then enter "window.name" and tell me what it prints out.

deafsquad commented 9 years ago

hi,

google changed the url for apps (now called google for Work) so it is now https://docs.google.com/presentation/d/... so https://docs.google.com/presentation/* should take care for all instances.

window.name shows "punch_speaker_notes__x" as you already check for in your code so i was not able to reproduce why your script is not firing up any hint how i could debug to the place where it hangs?

Jonathan Potter notifications@github.com schrieb am Mo., 4. Mai 2015 um 18:21 Uhr:

Thanks for the bug report! It's going to be a little hard to figure out the problem since I probably won't be able to reproduce it on my computer. But if you're willing to try some things out for me, we might be able to get to the bottom of this.

First things first. What's the URL of the document you're viewing? This extension only runs on pages that match " https://docs.google.com/presentation/" or " https://docs.google.com/a//presentation/*". I thought that covered all alternatives but maybe not.

Next let me know the name of the speaker notes window. You can find this by presenting with speaker notes and then while the speaker notes window is focused open the javascript console (More Tools > JavaScript Console). Then enter "window.name" and tell me what it prints out.

— Reply to this email directly or view it on GitHub https://github.com/jpotterm/chrome-resizable-speaker-notes/issues/1#issuecomment-98771126 .

jpotterm commented 9 years ago

Ok, good to know. But since that's already a pattern I'm using the extension should work for you. Is it still broken?

deafsquad commented 9 years ago

thats why i wrote you i do not understand why it is not working for me and as i see no point where to debug i do not think i can help here