jppampin / omaha

Automatically exported from code.google.com/p/omaha
Apache License 2.0
1 stars 0 forks source link

Log message in installer_wrapper.cc dereferences hresult as string #37

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This one is quite simple so I won't fill in a full report. Patch below.

goopdate/installer_wrapper.cc at SVN rev 109.

@@ -420,7 +420,7 @@
   Process p(executable_path, NULL);
   HRESULT hr = p.Start(command_line, user_token);
   if (FAILED(hr)) {
-    OPT_LOG(LE, (_T("[p.Start fail][hr][%s][%s]"),
+    OPT_LOG(LE, (_T("[p.Start fail][0x%x][%s][%s]"),
         hr, executable_path, command_line));
     set_error_extra_code1(static_cast<int>(hr));
     return GOOPDATEINSTALL_E_INSTALLER_FAILED_START;

Original issue reported on code.google.com by ben.chal...@red-gate.com on 23 Jan 2012 at 2:35

GoogleCodeExporter commented 9 years ago
Thanks Ben :)

Original comment by ryanmyers@google.com on 23 Jan 2012 at 6:44