jprante / elasticsearch-knapsack

Knapsack plugin is an import/export tool for Elasticsearch
Apache License 2.0
472 stars 77 forks source link

ArchiveSession UTF-8 Encoding #86

Closed masda70 closed 8 years ago

masda70 commented 8 years ago

ArchiveSession's write method should use "UTF-8" as the encoding for the payload's buffer:

byte[] buf = packet.payload().getBytes("UTF-8");

I don't know if there are any negative implications to this change.

However, I want to add for this reason and some others, knapsack (1.7.2) has caused more trouble than the time I thought it would save me for my particular reindexing need (not accounting for CPU time). I did not find an existing out-of-the-box (and efficient) alternative, so I ended up coding my own solution.

jprante commented 8 years ago

Thanks for the hint, much appreciated.

jprante commented 8 years ago

Fixed in 2.0.0-rc1.0, 1.7.2.1, 1.6.2.1, 1.5.2.2, 1.4.5.1, 1.3.4.1