Export: fail fast on bad parameters

jprante / elasticsearch-knapsack

Knapsack plugin is an import/export tool for Elasticsearch

Apache License 2.0

472 stars 77 forks source link

Closed btiernay closed 11 years ago

btiernay commented 11 years ago

I think this plugin could be greatly improved by failing fast on the following checks, before asynchronously returning:

Cluster 'yellow' check
ConnectionFactory factory = service.getConnectionFactory(scheme);
Connection<Session> connection = factory.getConnection(URI.create(scheme + ":" + target));

These operations should be moved out of the spawned thread, and any exceptions caught and returned before signaling ok.

jprante commented 11 years ago

Included in 2.0.2

btiernay commented 11 years ago

@jprante Awesome, thanks!