search

jprendes / emception

Run Emscripten in the browser
Other
285 stars 35 forks source link

Error loading python.data #16

Closed kevinaangstadt closed 1 year ago

kevinaangstadt commented 1 year ago

I am trying to build and run the demo locally on a fresh clone of commit 3660655 (the latest commit as of writing). All steps appear to succeed during the build.

When I launch the demo in the browser, emception fails to load. I see a 404 error trying to get /python.data. I found this file in build/cypthon/python.data. If I copy this into build/demo the demo makes it a bit further, but then there is a FS error (number 20) thrown by python.mjs, so I suspect this is not the correct python.data file.

The demo branch does load emception properly, so there seems to be a discrepancy between what the build scripts produce and what is pushed to that branch. Any tips or pointers would be greatly appreciated!

jprendes commented 1 year ago

Normally, the build scripts patches upstream cpython to avoid using the python.data file. That's what the wasm-preload option in the patch should be doing. Try removing the packs, emception and cpython folders from the build directory, and run build-with-docker.sh again. Would you mind sharing the generated log?

kevinaangstadt commented 1 year ago

Ah! I didn't look back far enough in the logs to find the failure. Git failed to check out the required commit of cypthon before attempting to apply the patch. It looks like #14 inadvertently caused this issue by only cloning the most recent commit. After adding git fitch origin b8a9f13abb61bd91a368e2d3f339de736863050f to build-python.sh, I was able to get the demo running.

jprendes commented 1 year ago

Thanks for the update! Would you mind creating a PR?