search

jpribyl / action-docker-layer-caching

🐳 Enable Docker layer caching in GitHub Actions
https://github.com/marketplace/actions/docker-layer-caching
MIT License
59 stars 10 forks source link

Update README for marketplace listing #5

Closed mendhak closed 2 years ago

mendhak commented 2 years ago

Hi there thanks for this, it's working!

Please consider this PR, it is updating the README so your marketplace listing has the right action and version in it. And the badges too.

I think it should show up in the Marketplace the next time the action is published.

jpribyl commented 2 years ago

Awesome! Thank you so much- been on my todo list to update that! - LGTM + merged. Didn't seem like I could push updates to your branch so I opened a new one here to run prettier + update the deprecation notice as well

https://github.com/jpribyl/action-docker-layer-caching/pull/6

Sorry about the funky git flow, I'm gonna see if I can figure out how to open up permissions on this repo so that anyone may push a branch + only main is protected

mendhak commented 2 years ago

Nice one thanks. You should be able to push to people's branch, but Github doesn't make it obvious how and the commands aren't intuitive. I did a write up of it, if you ever want to try it in the future: https://code.mendhak.com/update-fork-pull-request/

That way you shouldn't need to open up your repo (and forks are free).
But if you still want to let people push directly, from what I've seen, the best you can do is invite Collaborators. (I think)

I'd be surprised if Github had a way to allow anyone to push to a repo, I think Github considers it a security risk actually, because people take advantage of Github Actions to mine crypto or do other kinds of attacks. That's why in this example when I did my PR you probably had to allow the actions to run.